fix: improved the huggingface emdeddings component, to handle local inference and serverless inference #6292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwinjosechittilappilly
requested review from
anovazzi1,
ogabrielluiz and
italojohnny
github-actions
bot
added
bug
dosubot
bot
added
the
size:S
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several updates to the
src/backend/base/langflow/components/embeddings/huggingface_inference_api.pyfile, focusing on improving the handling of API keys and local URLs for HuggingFace embeddings. The most important changes include updating the advanced setting for the API key input, expanding the list of local URLs, and modifying the default API key for local deployment.Improvements to API key handling:
class HuggingFaceInferenceAPIEmbeddingsComponent(LCEmbeddingsModel): Changed theadvancedsetting for theapi_keyinput fromTruetoFalseto make it more accessible.Enhancements to local URL handling:
def create_huggingface_embeddings(: Expanded the list of local URLs to includehttp://0.0.0.0andhttp://docker, and added a check to ensurehuggingface.cois not in the URL for local deployment.def create_huggingface_embeddings(: Modified the default API key for local deployment fromDummyAPIKeyForLocalDeploymenttoAPIKeyForLocalDeploymentfor better clarity.Additional comments:
langchain_huggingfacein the next update.https://www.loom.com/share/1e6885358434465a94ef72ea38ec4eec?sid=d2a8c171-fb05-499f-8364-7fb51350828d