feat: Use pyproject standardized dependency-groups #6689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
cbornet
commented
Feb 18, 2025
| @@ -208,40 +240,5 @@ all = [ | |||
| "ctransformers>=0.2" | |||
| ] | |||
|
|
|||
| # Development dependencies | |||
| dev = [ | |||
There was a problem hiding this comment.
These where an "extras". I think it was not useful ?
This PR changes it it to the dev group.
There was a problem hiding this comment.
We will probably need to update the CI workflows and possibly Dockerfiles, as well.
There was a problem hiding this comment.
Yes. I updated the CI workflow.
For Dockerfiles, I think it's OK (the --no-dev flag should still work)
There was a problem hiding this comment.
I also removed all the --dev from uv sync as they are superfluous.
github-actions
bot
added
enhancement
github-actions
bot
added
enhancement
CodSpeed Performance ReportMerging #6689 will degrade performances by 16.29%Comparing Summary
Benchmarks breakdown
|
github-actions
bot
added
enhancement
ogabrielluiz
approved these changes
Feb 20, 2025
github-actions
bot
added
enhancement
github-actions
bot
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use pyproject standardized dependency-groups