fix(openai): implement aclose on async stream responses #1112
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greptile Summary
Disclaimer: Experimental PR review
Added
aclose
method toLangfuseResponseGeneratorAsync
class to properly handle cleanup of async streaming responses from OpenAI.aclose
method in/langfuse/openai.py
to mirror existingclose
functionality for async streamsaclose
method to ensure proper resource cleanupImportant
Adds
aclose()
method toLangfuseResponseGeneratorAsync
inlangfuse/openai.py
for closing async stream responses.aclose()
method toLangfuseResponseGeneratorAsync
inlangfuse/openai.py
to close async stream responses.This description was created by
for beb1d98. It will automatically update as commits are pushed.