Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix bug by adding missing required parameters for anthropic claude #142

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ysekiy
Copy link

@ysekiy ysekiy commented Jan 11, 2025

Summary

The Bedrock Official Plugin was in an uninstallable state. I found that the cause of the error was missing parameters, so this Pull Request fixes the parameters.

Related Issue

@kurokobo
Copy link

@kurokobo
Copy link

The issue #141 can be closed since this has been fixed by the changes on the Plugin Daemon side.: langgenius/dify-plugin-daemon@b2f77fd
The files for models in Bedrock can remain as they are and do not require any modifications.

@ysekiy
Copy link
Author

ysekiy commented Jan 13, 2025

Thank you for your prompt response. I have reviewed the changes. However, the bug is still reproducible according to the official documentation. To maintain visibility of the bug, I plan to keep this issue open until the line is updated. Please let me know if this approach is acceptable. If it conflicts with the development policy of dify, I will follow the dify development guidelines.

@kurokobo
As an enthusiastic contributor, I would appreciate your opinion on this matter.

@kurokobo
Copy link

Based on past experiences, issues are often closed at the stage when their fixes are merged (even before release). I frequently see comments on closed issues stating, "It's not fixed" and then "Please wait for the next release." 😃
Therefore, you are free to leave these issue and PR open, but there also is a possibility that the Dify Team may decide to close these as resolved.

I think the fix for #141 will be released during the next beta release if it's planned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants