Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update document and segment word count #10449

Merged
merged 4 commits into from
Nov 8, 2024

Conversation

JohnJyong
Copy link
Contributor

@JohnJyong JohnJyong commented Nov 8, 2024

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

update document and segment word count

Fixes #10335
Fixes #10011

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. 📚 documentation Improvements or additions to documentation labels Nov 8, 2024
@nadirvishun
Copy link

missing batch import segment in api/tasks/batch_create_segment_to_index_task.py

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 8, 2024
@crazywoola crazywoola merged commit 4f1a56f into main Nov 8, 2024
9 checks passed
@crazywoola crazywoola deleted the fix/document-word-count-is-incorrect branch November 8, 2024 09:32
AlwaysBluer pushed a commit to AlwaysBluer/dify that referenced this pull request Nov 14, 2024
idonotknow pushed a commit to AceDataCloud/Dify that referenced this pull request Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 documentation Improvements or additions to documentation lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
3 participants