Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(file_upload): correct validation method and add unit tests #10477

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

laipz8200
Copy link
Member

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

  • Fixed the validation call to use FileUploadConfig instead of FileExtraConfig.
  • Added unit tests for file upload manager to ensure proper configuration handling and defaults.
  • Enhanced validation and conversion logic under different configuration scenarios.

Fixes

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

- Fixed the validation call to use `FileUploadConfig` instead of `FileExtraConfig`.
- Added unit tests for file upload manager to ensure proper configuration handling and defaults.
- Enhanced validation and conversion logic under different configuration scenarios.
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Nov 8, 2024
@laipz8200 laipz8200 requested a review from crazywoola November 8, 2024 13:48
@dosubot dosubot bot added the 🐞 bug Something isn't working label Nov 8, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 8, 2024
@laipz8200 laipz8200 merged commit 172c7eb into main Nov 8, 2024
9 checks passed
@laipz8200 laipz8200 deleted the fix/correct-validation-method-and-add-unit-tests branch November 8, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants