Solution/role based app setting[WIP] #10946
Draft
+23
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a new is_admin property in the Account model and the corresponding utility method is_admin_role in the TenantAccountRole class. Additionally, it updates the AppService logic to prevent non-admin users from modifying the enable_site property. These changes enhance access control and ensure only administrators can manage critical application settings.
Key Changes:
Added is_admin property to the Account model to simplify admin checks.
Added is_admin_role static method to TenantAccountRole to encapsulate role-specific logic.
Updated AppService to include a check for current_user.is_admin before updating the enable_site property.
Included commented-out alternative implementation for handling the enable_site property for potential future use.
Fixes # (replace with the relevant issue number or remove if not applicable).