Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the token count at the iteration node #11235

Merged
merged 3 commits into from
Dec 9, 2024
Merged

Conversation

s2terminal
Copy link
Contributor

@s2terminal s2terminal commented Dec 1, 2024

Summary

fix #10655

I fixed the problem where the token count was not being added when using LLM in the iteration node.

Screenshots

Before: After
image image

"イテレーション" means "Iteration".

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 🐞 bug Something isn't working labels Dec 1, 2024
@crazywoola crazywoola requested a review from laipz8200 December 2, 2024 07:38
@laipz8200 laipz8200 requested a review from Nov1c444 December 2, 2024 08:02
@laipz8200
Copy link
Member

Please make checks pass first.

Nov1c444
Nov1c444 previously approved these changes Dec 8, 2024
@laipz8200
Copy link
Member

Thank you for the contribution, could you please resolve the conflicts before we merge it?

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 9, 2024
@laipz8200 laipz8200 merged commit c3c6a48 into langgenius:main Dec 9, 2024
6 checks passed
@s2terminal
Copy link
Contributor Author

Thank you for your help.

iamjoel pushed a commit that referenced this pull request Dec 16, 2024
Co-authored-by: -LAN- <laipz8200@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

For each node is not correctly counted in token usage
3 participants