Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: some typos using typos #11374

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

yihong0618
Copy link
Contributor

@yihong0618 yihong0618 commented Dec 5, 2024

Summary

This patch fix a lot of typos in api/ which is backend, and also found a typo bug caused bug in tools/wolframalpha

- if "souces" in response_data["queryresult"]:
+ if "sources" in response_data["queryresult"]:

using https://github.com/crate-ci/typos .

command:

cd api
typos --exclude '*.txt' --exclude '*.json' --exclude '*.svg' --exclude '*.js'

nit: some of the typos not fixed because that may cause problems I think I should careful leave them for now

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

Screenshots

Before: After:
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. 🐞 bug Something isn't working labels Dec 5, 2024
Copy link
Member

@crazywoola crazywoola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not include changes in tools/provider/builtin for now. :)

@yihong0618
Copy link
Contributor Author

ols/prov

copy will checkout them? just leave the bug fix diff is that OK?

@yihong0618
Copy link
Contributor Author

ols/prov

copy will checkout them, just leave the bug fix diff is that OK?

@crazywoola
Copy link
Member

ols/prov

copy will checkout them? just leave the bug fix diff is that OK?

Because we are migrating tools to another repo so we can not touch it for now.

Signed-off-by: yihong0618 <zouzou0208@gmail.com>
@yihong0618 yihong0618 force-pushed the hy/fix_lots_of_typos branch from 52f0089 to 56f52d5 Compare December 5, 2024 03:40
@yihong0618
Copy link
Contributor Author

ols/prov

copy will checkout them? just leave the bug fix diff is that OK?

Because we are migrating tools to another repo so we can not touch it for now.

thanks only fix the bug in them, and drop others

@yihong0618 yihong0618 changed the title fix: a lot of typos using typos fix: some typos using typos Dec 5, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 5, 2024
@crazywoola crazywoola merged commit 5669cac into langgenius:main Dec 5, 2024
5 checks passed
iamjoel pushed a commit that referenced this pull request Dec 16, 2024
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants