Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix model provider of vertex ai #11437

Merged

Conversation

kazukitakamatsu
Copy link
Contributor

Summary

This PR fixed the initialization process when the service account key is omitted in the model provider of Google Cloud Vertex AI.
The service account key was originally optional, but an error occurred when trying to json decode the string from the omitted case.

Screenshots

Before After
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Dec 6, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 8, 2024
@crazywoola crazywoola merged commit 4d7cfd0 into langgenius:main Dec 8, 2024
5 checks passed
iamjoel pushed a commit that referenced this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants