Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unit tests env will need clear too #11445

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

yihong0618
Copy link
Contributor

Summary

if we have dify env file .env the unit tests will failed too, because the .env timeout is 600 and the tests env is 60
like


example_env_file = '/private/var/folders/c3/51t_3cqj7bx98dq1ptyy0v700000gn/T/pytest-of-hyi/pytest-28/test_dify_config0/.env'

    def test_dify_config(example_env_file):
        # load dotenv file with pydantic-settings
        config = DifyConfig(_env_file=example_env_file)
    
        # constant values
        assert config.COMMIT_SHA == ""
    
        # default values
        assert config.EDITION == "SELF_HOSTED"
        assert config.API_COMPRESSION_ENABLED is False
        assert config.SENTRY_TRACES_SAMPLE_RATE == 1.0
    
        # annotated field with default value
>       assert config.HTTP_REQUEST_MAX_READ_TIMEOUT == 60
E       AssertionError: assert 600 == 60
E        +  where 600 = DifyConfig(ENTERPRISE_ENABLED=False, CAN_REPLACE_LOGO=False, SENTRY_DSN='', SENTRY_TRACES_SAMPLE_RATE=1.0, SENTRY_PROF..., CONSOLE_CORS_ALLOW_ORIGINS=['http://127.0.0.1:3000', '*'], WEB_API_CORS_ALLOW_ORIGINS=['http://127.0.0.1:3000', '*']).HTTP_REQUEST_MAX_READ_TIMEOUT

/Users/hyi/prs/dify/api/tests/unit_tests/configs/test_dify_config.py:53: AssertionError

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

Screenshots

Before After
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Signed-off-by: yihong0618 <zouzou0208@gmail.com>
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 🐞 bug Something isn't working labels Dec 7, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 9, 2024
@crazywoola crazywoola merged commit 7ff42b1 into langgenius:main Dec 9, 2024
5 checks passed
iamjoel pushed a commit that referenced this pull request Dec 16, 2024
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants