Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove mermail render cache #11470

Merged
merged 1 commit into from
Dec 9, 2024
Merged

remove mermail render cache #11470

merged 1 commit into from
Dec 9, 2024

Conversation

VoidIsVoid
Copy link
Contributor

Summary

In version 0.13.1, there will be a render bug when render a flowchart in a stream mode response.
This is because chartId in web/app/components/base/mermaid/index.tsx nerver changed when props.PrimitiveCode is different, which made it easy to render the same cache svg by the same chartId.
When props.PrimitiveCode changed, it will create to many cache in localstorage in the middle of stream without a cleaning stratege.
So I made this pr to remove the cache.

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

Screenshots

Before After
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. ☕️ typescript Pull request that update TypeScript code. labels Dec 9, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 9, 2024
@crazywoola crazywoola merged commit a594e25 into langgenius:main Dec 9, 2024
4 checks passed
iamjoel pushed a commit that referenced this pull request Dec 16, 2024
Co-authored-by: Gimling <huangjl@ruyi.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files. ☕️ typescript Pull request that update TypeScript code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants