Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: better opendal tests #11569

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

yihong0618
Copy link
Contributor

@yihong0618 yihong0618 commented Dec 12, 2024

This patch use better opendal tests that use its own tests and delete the dir created during the tests after unit test done. also fix OpenDALStorage exists api for opendal python binding do not support the exists for now, and add FIXME to info us.

more info can check this commit, opendal tests now, may add a empty dir and may push by accident...:

1fe3c0c

Summary

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

Screenshots

Before After
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

This patch use better opendal tests that use its own tests and
delete the dir created during the tests after unit test done.
also fix OpenDALStorage exists api for opendal python binding do
not support the exists for now, and add FIXME to info us.

Signed-off-by: yihong0618 <zouzou0208@gmail.com>
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. 🐞 bug Something isn't working labels Dec 12, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 12, 2024
@crazywoola
Copy link
Member

Cool

@crazywoola crazywoola merged commit 1807436 into langgenius:main Dec 12, 2024
5 checks passed
iamjoel pushed a commit that referenced this pull request Dec 16, 2024
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
AlwaysBluer pushed a commit to AlwaysBluer/dify that referenced this pull request Dec 18, 2024
…m-vdb

* 'lindorm-vdb' of github.com:AlwaysBluer/dify:
  Fix/pdf preview in build (langgenius#11621)
  feat(devcontainer): add alias to stop Docker containers (langgenius#11616)
  ci: better print version for ruff to check the change (langgenius#11587)
  feat(model): add vertex_ai Gemini 2.0 Flash Exp (langgenius#11604)
  fix: name of llama-3.3-70b-specdec (langgenius#11596)
  Added new models and Removed the deleted ones for Groq langgenius#11455 (langgenius#11456)
  [ref] use one method to get boto client for aws bedrock (langgenius#11506)
  chore: translate i18n files (langgenius#11577)
  fix: support mdx files close langgenius#11557 (langgenius#11565)
  fix: change workflow trace id (langgenius#11585)
  Feat: dark mode for logs and annotations (langgenius#11575)
  Lindorm vdb (langgenius#11574)
  feat: add gemini-2.0-flash-exp (langgenius#11570)
  fix: better opendal tests (langgenius#11569)
  Fix: RateLimit requests were not released when a streaming generation exception occurred (langgenius#11540)
  chore: translate i18n files (langgenius#11545)
  fix: workflow continue on error doc link (langgenius#11554)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants