Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: run vdb tests on TiDB Vector with docker in CI tests #11645

Merged
merged 4 commits into from
Dec 15, 2024
Merged

test: run vdb tests on TiDB Vector with docker in CI tests #11645

merged 4 commits into from
Dec 15, 2024

Conversation

bowenliang123
Copy link
Contributor

@bowenliang123 bowenliang123 commented Dec 13, 2024 •
edited
Loading

Summary

Screenshots

image

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@bowenliang123 bowenliang123 changed the title Run vdb tests with TiDB vector Run vdb tests on TiDB Vector with docker compose Dec 13, 2024
@bowenliang123 bowenliang123 force-pushed the vdb-test-tidb branch 2 times, most recently from b72bee4 to ebd34e9 Compare December 13, 2024 16:05
@bowenliang123 bowenliang123 marked this pull request as ready for review December 13, 2024 17:00
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. 👻 feat:rag Embedding related issue, like qdrant, weaviate, milvus, vector database. labels Dec 13, 2024
@bowenliang123
Revert "latest"
6c192cb 
This reverts commit f7b9a62.
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Dec 13, 2024
@bowenliang123
Reapply "latest"
aaf6b78 
This reverts commit 6c192cb.
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Dec 13, 2024
@bowenliang123
Copy link
Contributor Author

cc @JohnJyong @laipz8200 @takatost

@bowenliang123 bowenliang123 changed the title Run vdb tests on TiDB Vector with docker compose test: run vdb tests on TiDB Vector in CI tests Dec 15, 2024
@bowenliang123 bowenliang123 changed the title test: run vdb tests on TiDB Vector in CI tests test: run vdb tests on TiDB Vector with docker in CI tests Dec 15, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 15, 2024
@crazywoola crazywoola merged commit 924b4fe into langgenius:main Dec 15, 2024
7 checks passed
@bowenliang123 bowenliang123 deleted the vdb-test-tidb branch December 15, 2024 09:33
@bowenliang123
Copy link
Contributor Author

Thanks for the merging.

iamjoel pushed a commit that referenced this pull request Dec 16, 2024
@bowenliang123 @iamjoel
test: run vdb tests on TiDB Vector with docker in CI tests (#11645)
108c1ec
@gakugaku gakugaku mentioned this pull request Dec 16, 2024
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazywoola crazywoola crazywoola approved these changes

Assignees
No one assigned
Labels
👻 feat:rag Embedding related issue, like qdrant, weaviate, milvus, vector database. lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bowenliang123 @crazywoola