Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add last_refresh_time to track the validity of is_other_tab_refreshing #12517

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

douxc
Copy link
Collaborator

@douxc douxc commented Jan 9, 2025

…eshing sign

Summary

Sometimes page may block cause is_other_tab_refreshing always equal 1, add timestamp to track the validity of is_other_tab_refreshing

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

Screenshots

Before After
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. 🐞 bug Something isn't working labels Jan 9, 2025
Copy link
Collaborator

@WTW0313 WTW0313 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 9, 2025
@douxc douxc merged commit b7a4e39 into main Jan 9, 2025
8 checks passed
@douxc douxc deleted the fix/remove-refreshing-sign branch January 9, 2025 02:40
alexcodelf pushed a commit to alexcodelf/dify that referenced this pull request Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants