-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: embedding demension change bug #12914
base: main
Are you sure you want to change the base?
Conversation
|
replicate step by step |
api/services/dataset_service.py
Outdated
indexing_documents = ( | ||
db.session.query(Document) | ||
.filter( | ||
Document.dataset_id == dataset_id, | ||
Document.indexing_status == "indexing", | ||
) | ||
.all() | ||
) | ||
if len(indexing_documents) > 0: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's risky in huge memory usage to loading all the docs risks for.
Count the docs on db side instead.
Summary
Close #12913
Screenshots
Checklist
Important
Please review the checklist below before submitting your pull request.
dev/reformat
(backend) andcd web && npx lint-staged
(frontend) to appease the lint gods