Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update .env.example to fix MILVUS_URI default value #13140

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update .env.example to fix MILVUS_URI default value #13140

wants to merge 3 commits into from

Conversation

codingjaguar
Copy link

@codingjaguar codingjaguar commented Feb 2, 2025 •
edited
Loading

Summary

The MILVUS_URI with localhost is not reachable from another docker container. Changed to the special DNS name host.docker.internal to fix the problem.

See detailed issue report in
https://discord.com/channels/1160323594396635310/1335159004598370376/1335281419240607884

Screenshots

Before After
before after

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Fix the documentation about Milvus URI setting. dify-docs#472
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@codingjaguar
Update .env.example to fix MILVUS_URI default value
7164612 
The MILVUS_URI with localhost is not reachable from another docker container. Changed to the special DNS name `host.docker.internal` to fix the problem.

See detailed issue report in
https://discord.com/channels/1160323594396635310/1335159004598370376/1335281419240607884
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. dependencies Pull requests that update a dependency file labels Feb 2, 2025
codingjaguar
codingjaguar commented Feb 2, 2025
View reviewed changes
docker/.env.example Outdated Show resolved Hide resolved
codingjaguar
codingjaguar commented Feb 2, 2025
View reviewed changes
docker/.env.example Outdated Show resolved Hide resolved
codingjaguar
codingjaguar commented Feb 2, 2025
View reviewed changes
docker/.env.example Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@codingjaguar