Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: not install libmagic raise error #13146

Merged
merged 2 commits into from
Feb 3, 2025
Merged

Conversation

hjlarry
Copy link
Contributor

@hjlarry hjlarry commented Feb 2, 2025

Summary

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

fix #13109

the import magic will raise error on different platforms if libmagic is not installed, on my local windows it will raise:

Error: While importing 'app', an ImportError was raised:

Traceback (most recent call last):
  File "c:\Users\hejl\PycharmProjects\dify\api\.venv\Lib\site-packages\flask\cli.py", line 245, in locate_app
    __import__(module_name)
  File "C:\Users\hejl\PycharmProjects\dify\api\app.py", line 37, in <module>
    app = create_app()
          ^^^^^^^^^^^^
  File "C:\Users\hejl\PycharmProjects\dify\api\app_factory.py", line 25, in create_app
    initialize_extensions(app)
  File "C:\Users\hejl\PycharmProjects\dify\api\app_factory.py", line 87, in initialize_extensions
    ext.init_app(app)
  File "C:\Users\hejl\PycharmProjects\dify\api\extensions\ext_blueprints.py", line 10, in init_app
    from controllers.console import bp as console_app_bp
  File "C:\Users\hejl\PycharmProjects\dify\api\controllers\console\__init__.py", line 26, in <module>
    from .remote_files import RemoteFileInfoApi, RemoteFileUploadApi
  File "C:\Users\hejl\PycharmProjects\dify\api\controllers\console\remote_files.py", line 9, in <module>
    from controllers.common import helpers
  File "C:\Users\hejl\PycharmProjects\dify\api\controllers\common\helpers.py", line 10, in <module>
    import magic
  File "c:\Users\hejl\PycharmProjects\dify\api\.venv\Lib\site-packages\magic\__init__.py", line 209, in <module>
    libmagic = loader.load_lib()
               ^^^^^^^^^^^^^^^^^
  File "c:\Users\hejl\PycharmProjects\dify\api\.venv\Lib\site-packages\magic\loader.py", line 49, in load_lib
    raise ImportError('failed to find libmagic.  Check your installation')
ImportError: failed to find libmagic.  Check your installation

Guessing the mimetype for every user isn't particularly important; a warning message should suffice.

Screenshots

Before After
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. 🐞 bug Something isn't working labels Feb 2, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 3, 2025
@crazywoola crazywoola merged commit 304467e into langgenius:main Feb 3, 2025
6 checks passed
@laipz8200
Copy link
Member

Awesome job, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ImportError: failed to find libmagic. Check your installation
3 participants