fix: set indexing technique from dataset during update-by-text #13155
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an
invalid_param
error in theupdate-by-text
API endpoint.The error occurs when
indexing_technique
is not provided to theKnowledgeConfig
validation, resulting in a Pydantic validation error.Example of the current error:
Response:
The
indexing_technique
parameter is only meant to be set during document creation or initial upload, as shown in the current dataset_service implementation. For update operations, this field should not be required since it's already set and immutable.This PR fixes the issue by defaulting to the dataset's existing
indexing_technique
value in the update API endpoint.resolves #12465
Screenshots
Checklist
Important
Please review the checklist below before submitting your pull request.
dev/reformat
(backend) andcd web && npx lint-staged
(frontend) to appease the lint gods