refactor(models): Refine MessageAgentThought SQLAlchemy typing#27749
Conversation
Summary of ChangesHello @laipz8200, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the type safety and clarity of the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request refines the SQLAlchemy typing for the MessageAgentThought model, aligning it with modern SQLAlchemy 2.0 practices. The changes correctly add Mapped annotations and use Decimal for pricing fields, which improves type safety and consistency for static analysis. I have one suggestion to further improve type safety for the created_by_role field by using the CreatorUserRole enum.
96d1680 to
2061c81
Compare
583860f to
72eae50
Compare
72eae50 to
85e6117
Compare
45f9730 to
63cb837
Compare
Co-authored-by: Asuka Minato <i@asukaminato.eu.org>
63cb837 to
bb857df
Compare
Summary
Mapped[...]annotations toMessageAgentThoughttext, numeric, and temporal columns for SQLAlchemy 2.0 typing.Decimaltyping so static analysis can treat message cost calculations consistently.Screenshots
Checklist
dev/reformat(backend) andcd web && npx lint-staged(frontend) to appease the lint gods