Skip to content

feat: get plan bulk with cache#30339

Merged
hjlarry merged 3 commits intomainfrom
feat-batch-get-billing-plan-with-cache
Dec 30, 2025
Merged

feat: get plan bulk with cache#30339
hjlarry merged 3 commits intomainfrom
feat-batch-get-billing-plan-with-cache

Conversation

@hj24
Copy link
Contributor

@hj24 hj24 commented Dec 29, 2025

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. 💪 enhancement New feature or request labels Dec 29, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @hj24, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request implements a new, highly efficient, and resilient caching layer for retrieving tenant subscription plans in bulk. By introducing get_plan_bulk_with_cache, the system can now leverage Redis to store and retrieve plan data, significantly reducing the number of calls to the external billing API, especially in batch processing scenarios. The implementation includes sophisticated logic to manage cache consistency, handle Redis operational failures, and validate cached data, ensuring reliable plan retrieval. Furthermore, the existing bulk plan fetching method has been made more robust by adding error handling that allows it to continue processing valid plans even when encountering malformed data for specific tenants.

Highlights

  • New Cached Billing Plan Retrieval: Introduced get_plan_bulk_with_cache in BillingService to fetch tenant subscription plans, utilizing Redis for caching to reduce direct billing API load.
  • Robust Caching Logic: The new caching mechanism handles various scenarios including cache hits, misses, partial hits, and gracefully falls back to the billing API upon Redis errors or invalid cached data.
  • Enhanced Error Handling for Bulk Plans: Improved the existing get_plan_bulk method to log and skip individual invalid tenant plans during bulk retrieval, preventing a single malformed entry from failing the entire batch.
  • Comprehensive Test Coverage: Added extensive integration tests for the new caching functionality, covering edge cases like Redis failures, invalid cache data, and TTL expiration, alongside a new unit test for the improved get_plan_bulk error handling.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@hj24 hj24 requested review from hjlarry and removed request for QuantumGhost December 29, 2025 11:30
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a caching layer for bulk fetching tenant plans, which is a great feature for improving performance and reducing load on the billing API. The implementation is solid, using Redis mget and pipelines for efficient batch operations, and includes robust error handling and fallbacks. The accompanying integration tests are comprehensive and cover many edge cases, which is excellent.

I have a couple of minor suggestions to improve code clarity and style. One is about simplifying a redundant exception handler, and the other is a small style fix in the new tests.

Copy link
Contributor

@hjlarry hjlarry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💪 enhancement New feature or request lgtm This PR has been approved by a maintainer size:XL This PR changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments