Skip to content

fix: [xxx](xxx) render as xxx](xxx)#30392

Merged
crazywoola merged 3 commits intolanggenius:mainfrom
fatelei:issue-30359
Dec 31, 2025
Merged

fix: [xxx](xxx) render as xxx](xxx)#30392
crazywoola merged 3 commits intolanggenius:mainfrom
fatelei:issue-30359

Conversation

@fatelei
Copy link
Contributor

@fatelei fatelei commented Dec 30, 2025

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

fix #30402

  1. clean_processor.py - Fixed URL removal to preserve markdown links and images

The previous implementation only protected markdown image URLs (alt) during URL removal, which caused:

  • Regular markdown links (text) to have their URL part stripped
  • Link text (which might itself be a URL) to be removed

Fix:

  • Now protects both markdown links and images with placeholders before URL removal
  • Changed placeholder format from MARKDOWN_IMAGE_URL_N to generic MARKDOWN_PLACEHOLDER_N
  • Added tuple structure for placeholders: (link_type, text/url, url) to distinguish links from images
  • Changed URL regex from https?://[^\s)]+ to https?://\S+ for better matching
  • Restores links as text and images as alt after cleanup
  1. text_processing_utils.py - Preserve leading markdown links

Added check to prevent remove_leading_symbols() from stripping markdown links at the start of text:

markdown_link_pattern = r'^\[([^\]]+)\]\((https?://[^)]+)\)'
if re.match(markdown_link_pattern, text):
   return text

This ensures links like OpenAI at the beginning of text are preserved.

Screenshots

Before After
... ...

before

Screen.Recording.2025-12-30.at.22.31.16.mov

after

Screen.Recording.2025-12-30.at.20.18.49.mov

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Dec 30, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @fatelei, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical issue in the text extraction process where markdown links and images were not being correctly preserved. The changes ensure that the system accurately retains the structure and content of these elements, preventing data loss and improving the fidelity of extracted text by modifying the URL cleaning logic and protecting leading markdown links.

Highlights

  • Enhanced Markdown Link and Image Preservation: The clean_processor.py module has been updated to correctly preserve both markdown links (e.g., [text](url)) and markdown images (e.g., ![alt](url)) during URL removal, preventing the loss of link text or URLs.
  • Leading Markdown Link Protection: The text_processing_utils.py module now includes logic to prevent the remove_leading_symbols() function from inadvertently stripping valid markdown links that appear at the very beginning of a text string.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses an issue where hyperlink text and target URLs were being lost during text cleaning. The changes introduce logic to protect markdown links and images by replacing them with placeholders before stripping URLs, and also ensures that markdown links at the beginning of a text are not removed.

The approach is solid, but I've identified a few areas for improvement:

  • The new logic for handling markdown images still loses the image's alt text. I've suggested changes to correctly capture and restore it.
  • The updated regular expression for detecting URLs is a bit too greedy and might incorrectly capture trailing punctuation. I've recommended a more constrained pattern.
  • The pattern for detecting leading markdown links can be made more robust to handle cases with empty link text.

These suggestions aim to make the fix more complete and robust.

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Dec 30, 2025
@fatelei fatelei changed the title fix: fix extractor loses hyperlink text and target URL fix: [xxx](xxx) render as xxx](xxx) Dec 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

segment render [xxxx](xxxx) missing [

2 participants