fix: [xxx](xxx) render as xxx](xxx)#30392
Conversation
Summary of ChangesHello @fatelei, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical issue in the text extraction process where markdown links and images were not being correctly preserved. The changes ensure that the system accurately retains the structure and content of these elements, preventing data loss and improving the fidelity of extracted text by modifying the URL cleaning logic and protecting leading markdown links. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request addresses an issue where hyperlink text and target URLs were being lost during text cleaning. The changes introduce logic to protect markdown links and images by replacing them with placeholders before stripping URLs, and also ensures that markdown links at the beginning of a text are not removed.
The approach is solid, but I've identified a few areas for improvement:
- The new logic for handling markdown images still loses the image's alt text. I've suggested changes to correctly capture and restore it.
- The updated regular expression for detecting URLs is a bit too greedy and might incorrectly capture trailing punctuation. I've recommended a more constrained pattern.
- The pattern for detecting leading markdown links can be made more robust to handle cases with empty link text.
These suggestions aim to make the fix more complete and robust.
Important
Fixes #<issue number>.Summary
fix #30402
The previous implementation only protected markdown image URLs (
) during URL removal, which caused:
Fix:
Added check to prevent remove_leading_symbols() from stripping markdown links at the start of text:
This ensures links like OpenAI at the beginning of text are preserved.
Screenshots
before
Screen.Recording.2025-12-30.at.22.31.16.mov
after
Screen.Recording.2025-12-30.at.20.18.49.mov
Checklist
dev/reformat(backend) andcd web && npx lint-staged(frontend) to appease the lint gods