Skip to content

feat: allow pass hostname in docker env#30975

Merged
crazywoola merged 1 commit intolanggenius:mainfrom
fatelei:issue-30957
Jan 14, 2026
Merged

feat: allow pass hostname in docker env#30975
crazywoola merged 1 commit intolanggenius:mainfrom
fatelei:issue-30957

Conversation

@fatelei
Copy link
Contributor

@fatelei fatelei commented Jan 14, 2026

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

fix #30957

Screenshots

Before After
... ...

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint and make type-check (backend) and cd web && npx lint-staged (frontend) to appease the lint gods

@fatelei fatelei requested a review from QuantumGhost as a code owner January 14, 2026 08:04
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. 💪 enhancement New feature or request labels Jan 14, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @fatelei, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the SMTP client functionality by allowing users to define a specific local hostname for outgoing email connections via an environment variable. This feature provides greater control over how the application identifies itself to mail servers, which can be beneficial for compatibility with certain SMTP server configurations or for meeting specific network requirements. The change is implemented by reading SMTP_LOCAL_HOSTNAME and passing it to the underlying Python smtplib calls, with corresponding updates to the unit tests to validate this new parameter.

Highlights

  • SMTP Local Hostname Configuration: Introduced the ability to specify a local hostname for SMTP connections by reading the SMTP_LOCAL_HOSTNAME environment variable. This value is then passed to the smtplib.SMTP and smtplib.SMTP_SSL constructors.
  • Environment Variable Integration: The api/libs/smtp.py file now imports the os module to retrieve the SMTP_LOCAL_HOSTNAME environment variable, allowing dynamic configuration of the local hostname for outgoing emails.
  • Unit Test Updates: Updated existing unit tests in api/tests/unit_tests/libs/test_smtp_client.py and api/tests/unit_tests/tasks/test_mail_send_task.py to account for the new local_hostname parameter being passed to the smtplib constructors, ensuring the new functionality is correctly tested.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the functionality to specify a local hostname for SMTP connections via the SMTP_LOCAL_HOSTNAME environment variable. The implementation is correct and the accompanying test updates are appropriate. I have a couple of suggestions to improve maintainability and consistency with the existing configuration handling.

@fatelei fatelei force-pushed the issue-30957 branch 2 times, most recently from fca289a to aa8f219 Compare January 14, 2026 08:09
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Jan 14, 2026
@fatelei fatelei requested a review from laipz8200 as a code owner January 14, 2026 08:14
@fatelei fatelei force-pushed the issue-30957 branch 2 times, most recently from 2867c2d to 5e596b8 Compare January 14, 2026 08:26
QuantumGhost
QuantumGhost previously approved these changes Jan 14, 2026
Copy link
Collaborator

@QuantumGhost QuantumGhost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .env.example in api folder should be updated, too.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💪 enhancement New feature or request lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

emails fail with a 550 relay denied error if SMTP server is authenticate by IP WL

3 participants