Skip to content

Comments

fix: fix visibilityState event handle#31354

Merged
hyoban merged 2 commits intolanggenius:mainfrom
fatelei:issue-31352
Jan 22, 2026
Merged

fix: fix visibilityState event handle#31354
hyoban merged 2 commits intolanggenius:mainfrom
fatelei:issue-31352

Conversation

@fatelei
Copy link
Contributor

@fatelei fatelei commented Jan 21, 2026

Important

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

fix #31352
fix #31210
fix #31146

Screenshots

Before After
... ...

before

Screen.Recording.2026-01-21.at.20.39.40.mov

after

Screen.Recording.2026-01-21.at.20.34.35.mov

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran make lint and make type-check (backend) and cd web && npx lint-staged (frontend) to appease the lint gods

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jan 21, 2026
@github-actions github-actions bot added the web This relates to changes on the web. label Jan 21, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @fatelei, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily addresses a user experience issue within the workflow editor where the UI would unexpectedly refresh or reset when the browser tab regained focus, especially if a workflow was in an active or listening state. The changes introduce conditional logic to prevent this disruptive behavior, ensuring that the workflow's state remains consistent. Additionally, a minor configuration update was made to the TypeScript compiler options.

Highlights

  • Workflow Visibility State Handling: Refactored the visibilityState event handler in the workflow component to prevent the UI from resetting when a user returns to a visible tab if a workflow is currently running or listening for triggers. This ensures a more stable user experience during active workflow sessions.
  • TypeScript Configuration Update: Changed the jsx compiler option in tsconfig.json from react-jsx to preserve, which might be a compatibility adjustment for the build process.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes an issue with the visibilityState event handler to prevent UI state from being reset when a workflow run is active. The changes are logical and address the problem described. I've provided one suggestion to improve the code's readability and maintainability by refactoring the conditional logic to be more idiomatic and consistent. The changes to tsconfig.json are standard configuration updates and look good.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 22, 2026
@hyoban hyoban merged commit 4e7c1f4 into langgenius:main Jan 22, 2026
14 checks passed
fatelei added a commit that referenced this pull request Jan 22, 2026
lyzno1 pushed a commit that referenced this pull request Jan 22, 2026
@Linyilan-zz
Copy link

I have already updated to the latest version, but this issue still persists.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files. web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Trigger Lose Output Schema Workflow / Trigger / UI [Bug] Gmail trigger output variables are lost after exiting and re-opening the workflow.

3 participants