Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: no json output vars in front-page tool #5943

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Conversation

hjlarry
Copy link
Contributor

@hjlarry hjlarry commented Jul 4, 2024

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

fix #5798

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

I test it locally:

image

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jul 4, 2024
@zxhlyh zxhlyh requested a review from iamjoel July 4, 2024 02:37
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 4, 2024
@iamjoel iamjoel merged commit 46eca01 into langgenius:main Jul 4, 2024
3 checks passed
ZuzooVn added a commit to ZuzooVn/dify that referenced this pull request Jul 10, 2024
@ZuzooVn ZuzooVn mentioned this pull request Jul 10, 2024
1 task
crazywoola pushed a commit that referenced this pull request Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The tool returns json results but there are no json output variables available in the front-end page tool.
2 participants