Modify slack webhook url validation to allow workflow (#6041) #6042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
crazywoola
approved these changes
Jul 7, 2024
ZhouhaoJiang
added a commit
that referenced
this pull request
Jul 9, 2024
* refs/heads/main: (51 commits) feat: tailwind related improvement (#6085) feat: support AnalyticDB vector store (#5586) feat:add tts-streaming config and future (#5492) Feat: add index bar to select tool panel of workflow (#6066) bump to 0.6.13 (#6078) fix: Inconsistency Between Actual and Debug Input Variables (#6055) refactor: revamp picker block (#4227) chore: remove tsne unused code (#6077) fix: relative in overflow div (#5998) chore(action): move docker login above Set up QEMU in build-push action workflow (#6073) remove clunky welcome message (#6069) feat: add request_params field to jina_reader tool (#5610) fix azure stream download (#6063) chore: hide tracing introduce detail (#6049) Address the issue of the absence of poetry in the development container. (#6036) Fix authorization header validation to handle bearer types correctly - "authorization config header is required" error (#6040) Fix/6034 get random order of categories in explore and workflow is missing in zh hant (#6043) Modify slack webhook url validation to allow workflow (#6041) (#6042) fix(configs): Update pydantic settings in config files (#6023) Fix/incorrect parameter extractor memory (#6038) ...
laipz8200
pushed a commit
that referenced
this pull request
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Important
Please review the checklist below before submitting your pull request.
dev/reformat(backend) andcd web && npx lint-staged(frontend) to appease the lint godsDescription
Fixes #6041.
In order for slack_webhook to allow using workflow-based incoming webhook URL, I changed url validation string.
Type of Change
Testing Instructions
Since this is only tiny modification for validation URL string, no specific tests are required.