Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve variable type parameter error #6646

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Resolve variable type parameter error #6646

merged 1 commit into from
Jul 25, 2024

Conversation

majian159
Copy link
Contributor

@majian159 majian159 commented Jul 24, 2024 •
edited by crazywoola
Loading

Fixes #6633
Fixes #6643
Close #6635

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jul 24, 2024
@hjlarry
Copy link
Contributor

hjlarry commented Jul 24, 2024

LGTM

laipz8200
laipz8200 approved these changes Jul 25, 2024
View reviewed changes
Copy link
Collaborator

@laipz8200 laipz8200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thank you for your contribution.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 25, 2024
@laipz8200 laipz8200 merged commit a876baf into langgenius:main Jul 25, 2024
5 checks passed
laipz8200 pushed a commit that referenced this pull request Jul 25, 2024
@majian159 @laipz8200
Resolve variable type parameter error (#6646)
1d10c51
@hjlarry hjlarry mentioned this pull request Aug 6, 2024
Closed
5 tasks
cuiks pushed a commit to cuiks/dify that referenced this pull request Aug 6, 2024
@majian159 @cuiks
Resolve variable type parameter error (langgenius#6646)
a335321
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laipz8200 laipz8200 laipz8200 approved these changes

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
3 participants
@majian159 @hjlarry @laipz8200