Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issues #6655 Open ai tts issues #6696

Merged
merged 2 commits into from
Jul 26, 2024
Merged

Conversation

ic-xu
Copy link
Contributor

@ic-xu ic-xu commented Jul 26, 2024

fix #6655

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

This submission mainly involves the discovery and resolution of the following issues.

    1. The problem of the open AI tts not taking effect when switching voices;
    1. The bug that the front-end tts loading status must be displayed after the HTTP request is completed; The manifestation is that when the network is poor or the backend does not respond, the TTS playback component does not display a loading status, which leads to the front end not knowing whether the click was successful. It should display the status as loading immediately after the button is clicked.
    1. The bug that the front-end console errors when switching language and the voice of language does not exist.eg: switching Spanish;

Fixes #6696

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

The second and third points can be reproduced in the old version, while the first point is a submission error.

  • Test A
  • Test B

…g voices; 2. The bug that the front-end tts loading status must be displayed after the HTTP request is completed; 3. The bug that the front-end console errors when switching voices and the voice does not exist.
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. ☕️ typescript Pull request that update TypeScript code. 🐞 bug Something isn't working labels Jul 26, 2024
@ic-xu
Copy link
Contributor Author

ic-xu commented Jul 26, 2024

Mainly fix this Issues #6655

@crazywoola crazywoola self-requested a review July 26, 2024 02:48
@ic-xu ic-xu changed the title Open ai tts issues #6696 Open ai tts issues Jul 26, 2024
@ic-xu ic-xu changed the title issues #6696 Open ai tts issues issues #6655 Open ai tts issues Jul 26, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 26, 2024
@crazywoola crazywoola merged commit 6b50bb0 into langgenius:main Jul 26, 2024
5 checks passed
@crazywoola crazywoola mentioned this pull request Jul 27, 2024
5 tasks
cuiks pushed a commit to cuiks/dify that referenced this pull request Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files. ☕️ typescript Pull request that update TypeScript code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TTS voice cannot be changed with OpenAI
2 participants