Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix incorrect context size for jina-reranker-v2 model #7006

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

Nick17t
Copy link
Contributor

@Nick17t Nick17t commented Aug 6, 2024

Corrected the context_size parameter in jina-reranker-v2-base-multilingual.yaml from 8192 to 1024. The previous value was incorrect and could have led to performance issues or suboptimal results.

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. Close issue syntax: Fixes #<issue number>, see documentation for more details.

Fixes

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Corrected the `context_size` parameter in `jina-reranker-v2-base-multilingual.yaml` from 8192 to 1024. The previous value was incorrect and could have led to performance issues or suboptimal results.
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Aug 6, 2024
@Nick17t Nick17t changed the title jina-reranker: Fix incorrect context size for the model fix: Fix incorrect context size for jina-reranker-v2 model Aug 6, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 6, 2024
@crazywoola crazywoola merged commit 2699144 into langgenius:main Aug 6, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙️ feat:model-runtime lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants