Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SQL parser Error in MyScale vdb. #7255

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

MochiXu
Copy link
Contributor

@MochiXu MochiXu commented Aug 14, 2024

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

When MyScale SQL is generated, special characters are filtered to avoid SQL parsing errors.

Fixes #7254

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 🐞 bug Something isn't working labels Aug 14, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 14, 2024
@crazywoola crazywoola merged commit ba79088 into langgenius:main Aug 14, 2024
6 checks passed
ZhouhaoJiang added a commit that referenced this pull request Aug 16, 2024
* main: (107 commits)
  Fix: missing default value of type array object in conversation variable modal (#7309)
  fix: inability-to-add-node-and-change-the-edge (#7303)
  fix(api/services/app_dsl_service.py): Add conversation variables. (#7304)
  Feat/7023 dify editor can resize the image (#7296)
  fix(api/core/app/segments/segments.py): Fix file to markdown. (#7293)
  feat: support pinning, including, and excluding for Model Providers and Tools (#7283)
  chore(api): Introduce Ruff Formatter. (#7291)
  chore(api/core): Improve FileVar's type hint and imports. (#7290)
  feat: support OPENAI json_schema (#7258)
  feat: add chatgpt-4o-latest (#7289)
  feat(api/workflow): Add `Conversation.dialogue_count` (#7275)
  fix: can not input param value in tool test modal (#7281)
  Add jp translation for variable aggregator (#7277)
  fix: #7222 docstrings (#7276)
  fix ja-JP translation of secret values (#7279)
  fix: typo in upstage/llm/_position.yaml (#7286)
  fix: missed rerank_mode when convert to DatasetEntity (#7269)
  Fix SQL parser Error in MyScale vdb. (#7255)
  chore: allow download audio/video through HTTP node (#7224)
  Fix: support hide env & conversation var in prompt editor (#7256)
  ...
cuiks pushed a commit to cuiks/dify that referenced this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Text cannot be indexed using MyScale
2 participants