-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(api/core/model_runtime/model_providers/__base/large_language_model.py): Add TEXT type checker #7407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:S
This PR changes 10-29 lines, ignoring generated files.
⚙️ feat:model-runtime
labels
Aug 19, 2024
…l.py): Add TEXT type checker
laipz8200
force-pushed
the
fix/openai-structured-output
branch
from
August 19, 2024 10:34
d80ace8
to
d5f2e87
Compare
Yeuoly
approved these changes
Aug 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
laipz8200
changed the title
fix(api/core/model_runtime/model_providers/__base/large_language_model.py): Add TEXT type checker && upgrade openai package.
fix(api/core/model_runtime/model_providers/__base/large_language_model.py): Add TEXT type checker
Aug 19, 2024
takatost
approved these changes
Aug 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Scorpion1221
added a commit
to yybht155/dify
that referenced
this pull request
Aug 20, 2024
* commit '3d27d15f00d025185bf979a90a07f2767297703f': (297 commits) chore(*): Bump version 0.7.1 (langgenius#7389) upgrade: sandbox to 0.2.6 (langgenius#7410) add CrossRef builtin tool: doi query and title query (langgenius#7406) feat: OpenRouter add gpt-4o-2024-08-06 model (langgenius#7409) fix(api/core/model_runtime/model_providers/__base/large_language_model.py): Add TEXT type checker (langgenius#7407) fix:start of the period should be YYYY-MM-DD 00:00 (langgenius#7371) Feat: shortcut hook (langgenius#7385) chore: rearrange api python dependencies (langgenius#7391) feat: support xinference's auth system (langgenius#7369) chore: update ruff from 0.5.x to 0.6.x (langgenius#7384) feat: custom app icon (langgenius#7196) feat: add jina tokenizer tool (langgenius#7375) feat(api): support wenxin text embedding (langgenius#7377) chore: optimize ark model parameters (langgenius#7378) chore: add LOG_FILE to docker-compose (langgenius#7372) fix(api/services/workflow/workflow_converter.py): Add converrsation variable to workflow. (langgenius#7257) add base url for moonshot model (langgenius#7360) fix: keywords (langgenius#7357) feat: support siliconflow rerank (langgenius#7337) add workflowClient ,fix rename bug (langgenius#7352) ... # Conflicts: # api/configs/app_config.py # api/core/helper/code_executor/code_executor.py # api/core/tools/utils/message_transformer.py # api/core/workflow/nodes/tool/tool_node.py # api/poetry.lock # api/pyproject.toml # web/app/components/workflow/nodes/_base/components/variable/utils.ts # web/yarn.lock
cuiks
pushed a commit
to cuiks/dify
that referenced
this pull request
Sep 2, 2024
…l.py): Add TEXT type checker (langgenius#7407)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🐞 bug
Something isn't working
⚙️ feat:model-runtime
lgtm
This PR has been approved by a maintainer
size:S
This PR changes 10-29 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Important
Please review the checklist below before submitting your pull request.
dev/reformat
(backend) andcd web && npx lint-staged
(frontend) to appease the lint godsDescription
Fix parameters check when using the OpenAI structured output feature.
Type of Change
Testing Instructions
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration