Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: improve the check time of variable name in conversation and env var #7572

Merged
merged 1 commit into from
Aug 23, 2024
Merged

chore: improve the check time of variable name in conversation and env var #7572

merged 1 commit into from
Aug 23, 2024

Conversation

iamjoel
Copy link
Collaborator

@iamjoel iamjoel commented Aug 23, 2024

Description

Check the variable name on blur instead of on change in conversation and env var.

Fixes

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@iamjoel iamjoel requested a review from douxc August 23, 2024 07:05
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. 💪 enhancement New feature or request labels Aug 23, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 23, 2024
@iamjoel iamjoel merged commit fb75bd9 into main Aug 23, 2024
6 checks passed
@iamjoel iamjoel deleted the chore/impove-environment-var-valid-var-key branch August 23, 2024 07:08
cuiks pushed a commit to cuiks/dify that referenced this pull request Sep 2, 2024
@iamjoel @cuiks
chore: improve the check time of variable name in conversation and en…
127a432 
…v var (langgenius#7572)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@douxc douxc douxc approved these changes

Assignees
No one assigned
Labels
💪 enhancement New feature or request lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iamjoel @douxc