-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: rewrite Elasticsearch index and search code to achieve Elasticsearch vector and full-text search #7641
Conversation
Because ES 8.15.0 has a parameter k in the knn query statement in the query section, which 8.14.3 does not have, the test did not pass. Currently, I have modified the code to a knn query method that is compatible with both version 8.14.0 and 8.15.0. |
Yes, knn query is an important feature for ES vector. Are you testing it against both 8.14.x and 8.15.+? Otherwise, they are never well maintained. |
Co-authored-by: Bowen Liang <bowenliang@apache.org>
In the current ES, there are two way use knn query.
The second way is the way that has been supported since 8.0.0(https://www.elastic.co/guide/en/elasticsearch/reference/8.0/knn-search.html), so the current code has been changed to this way. But the lower version of ES only supports l2_norm, not cosine. So may need to do a compatibility later. |
I formatted a file and now the CI is all done~ |
…earch vector and full-text search (langgenius#7641) Co-authored-by: haokai <haokai@shuwen.com> Co-authored-by: crazywoola <100913391+crazywoola@users.noreply.github.com> Co-authored-by: Bowen Liang <bowenliang@apache.org> Co-authored-by: wellCh4n <wellCh4n@foxmail.com>
Checklist:
Important
Please review the checklist below before submitting your pull request.
dev/reformat
(backend) andcd web && npx lint-staged
(frontend) to appease the lint godsDescription
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. Close issue syntax:
Fixes #<issue number>
, see documentation for more details.Fixes
Type of Change
Testing Instructions
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration