Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct http timeout configs‘ default values and ignorance by HttpRequestNode #7762

Merged
merged 10 commits into from
Aug 30, 2024

Conversation

bowenliang123
Copy link
Contributor

@bowenliang123 bowenliang123 commented Aug 28, 2024

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

  • the min operator causes the explicitly set http timeout configs are ignored
  • replace min by using Annotated[int, Field(ge=10,)] to check http timeouts minimum
  • correct default timeouts

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • annotated field with default value
  • annotated field with configured value

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Aug 28, 2024
@bowenliang123 bowenliang123 changed the title bug: fix http timeout configs ignored by HttpRequestNode fix: http timeout configs ignored by HttpRequestNode Aug 28, 2024
@dosubot dosubot bot added the 🐞 bug Something isn't working label Aug 28, 2024
api/configs/feature/__init__.py Outdated Show resolved Hide resolved
api/configs/feature/__init__.py Outdated Show resolved Hide resolved
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Aug 29, 2024
@bowenliang123 bowenliang123 marked this pull request as draft August 29, 2024 13:14
@bowenliang123 bowenliang123 marked this pull request as ready for review August 29, 2024 13:50
@bowenliang123 bowenliang123 changed the title fix: http timeout configs ignored by HttpRequestNode fix: correct http timeout configs‘ default values and ignorance by HttpRequestNode Aug 29, 2024
Copy link
Collaborator

@laipz8200 laipz8200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 30, 2024
@laipz8200 laipz8200 merged commit 0c2a62f into langgenius:main Aug 30, 2024
6 checks passed
@bowenliang123 bowenliang123 deleted the fix-http-config branch August 31, 2024 00:27
cuiks pushed a commit to cuiks/dify that referenced this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants