Feat:remove estimation of embedding cost #7950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # api/controllers/console/datasets/datasets_document.py # api/services/dataset_service.py # web/app/components/datasets/create/step-two/index.tsx
…ing-cost' into feat/remove-estimation-of-embedding-cost
dosubot
bot
added
size:L
JohnJyong
approved these changes
Sep 4, 2024
5 tasks
mehrajagdish
pushed a commit
to Sbazar-GmbH/dify
that referenced
this pull request
Sep 6, 2024
Co-authored-by: jyong <718720800@qq.com>
|
Why was this feature removed? |
same question |
|
@crazywoola can you explain the reason for removing this feature? Thanks |
|
The cost of embedding is already very low. Calling the API to calculate the estimated price will affect efficiency. Many embedding models do not even have an API to calculate the price. |
cuiks
pushed a commit
to cuiks/dify
that referenced
this pull request
Sep 26, 2024
Co-authored-by: jyong <718720800@qq.com>
lau-td
pushed a commit
to heydevs-io/dify
that referenced
this pull request
Oct 23, 2024
Co-authored-by: jyong <718720800@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Important
Please review the checklist below before submitting your pull request.
dev/reformat(backend) andcd web && npx lint-staged(frontend) to appease the lint godsDescription
remove estimation of embedding cost.
Type of Change
Testing Instructions
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration