-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: change milvus init args from (host, port) to (url, token) #8019
Conversation
Signed-off-by: ChengZi <chen.zhang@zilliz.com>
Please update the docs here as well https://github.com/langgenius/dify-docs. All languages are required. :) Thanks. @zc277584121 |
langgenius/dify-docs#252 |
…enius#8019) Signed-off-by: ChengZi <chen.zhang@zilliz.com>
This is a breaking change. Users who are still using the MILVUS_HOST and MILVUS_PORT configuration will be unable to start their servers after this update. Would you consider optimizing this change or adding some documentation to guide users through the transition? |
…enius#8019) Signed-off-by: ChengZi <chen.zhang@zilliz.com>
Please add my wechat crazyphage @zc277584121 |
…enius#8019) Signed-off-by: ChengZi <chen.zhang@zilliz.com>
It's recommand to use URI and token in Milvus setting, instead of HOST, PORT. Here is an example to teach how to use URI and token in both Milvus and Zilliz: https://milvus.io/docs/build-rag-with-milvus.md#Load-data-into-Milvus
The ( HOST, PORT) appoach is about to depracate in the future, and it will bring confusion to the users.
In this PR, I changed the default setting from (host, port) to (uri , token), and depracated the unecessary
milvus_secure
. There was some duplicate code in the milvus_vector.py, and I refactor them using milvusClient, which made it more consice.Checklist:
Important
Please review the checklist below before submitting your pull request.
dev/reformat
(backend) andcd web && npx lint-staged
(frontend) to appease the lint godsDescription
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. Close issue syntax:
Fixes #<issue number>
, see documentation for more details.Close #8017
Type of Change
Testing Instructions
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration