Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add embedding models in fireworks provider #8728

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

yaoice
Copy link
Contributor

@yaoice yaoice commented Sep 24, 2024

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

Fixes #8726

Embedding model list in fireworks provider:https://docs.fireworks.ai/guides/querying-embeddings-models

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Embedding model list like following:
image
image

verify the embedding function in rag:
image
image
image
image

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. ⚙️ feat:model-runtime 👻 feat:rag Embedding related issue, like qdrant, weaviate, milvus, vector database. labels Sep 24, 2024
@yaoice yaoice force-pushed the feat/add-embedding-model branch from ace8551 to c2d8164 Compare September 24, 2024 12:59
Copy link
Member

@crazywoola crazywoola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please refer this #8724 as well :)

@yaoice yaoice force-pushed the feat/add-embedding-model branch from c2d8164 to 8843e4c Compare September 24, 2024 14:59
@yaoice
Copy link
Contributor Author

yaoice commented Sep 24, 2024

Please refer this #8724 as well :)

@crazywoola I've done.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 25, 2024
@crazywoola crazywoola merged commit 91f70d0 into langgenius:main Sep 25, 2024
6 checks passed
@yaoice yaoice deleted the feat/add-embedding-model branch September 25, 2024 01:40
hgnulb pushed a commit to hgnulb/dify that referenced this pull request Sep 26, 2024
cuiks pushed a commit to cuiks/dify that referenced this pull request Sep 26, 2024
lau-td pushed a commit to heydevs-io/dify that referenced this pull request Oct 23, 2024
idonotknow pushed a commit to AceDataCloud/Dify that referenced this pull request Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙️ feat:model-runtime 👻 feat:rag Embedding related issue, like qdrant, weaviate, milvus, vector database. lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add embedding model in Fireworks provider
2 participants