Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: start node input config modal raise 'variable name is required' #8793

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

hjlarry
Copy link
Contributor

@hjlarry hjlarry commented Sep 26, 2024

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

20240926_155809.mp4

when open the input config modal of start node, the first input element will auto focus, and then click any other elements will trigger checkVariableName. So when click the cancel button or other field type button will raise an error first, which is strange.

my solution is to make another html element auto focus, any other better solutions?

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

test locally.

  • Test not raise error
  • Test tab key worked

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. ☕️ typescript Pull request that update TypeScript code. 🐞 bug Something isn't working labels Sep 26, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 26, 2024
@crazywoola crazywoola merged commit 6240699 into langgenius:main Sep 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files. ☕️ typescript Pull request that update TypeScript code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants