fix(workflow/nodes/knowledge-retrieval/use-config): Preserve rerankin… #8842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g mode and weights in knowledge retrieval node
dosubot
bot
added
size:XS
crazywoola
approved these changes
Sep 27, 2024
|
Is there any related issues? |
I apologize for not linking a related issue. I'll create an issue and associate it with this PR right away. |
Please check #8854 |
ZhouhaoJiang
added a commit
that referenced
this pull request
Sep 29, 2024
* main: (77 commits) feat: add voyage ai as a new model provider (#8747) docs: add english versions for the files customizable_model_scale_out and predefined_model_scale_out (#8871) fix: #8843 event: tts_message_end always return in api streaming resp… (#8846) Add Jamba and Llama3.2 model support (#8878) fix(workflow): update tagging logic in GitHub Actions (#8882) chore: bump ruff to 0.6.8 for fixing violation in SIM910 (#8869) refactor: update Callback to an abstract class (#8868) feat: deprecate gte-Qwen2-7B-instruct embedding model (#8866) feat: add internlm2.5-20b and qwen2.5-coder-7b model (#8862) fix: customize model credentials were invalid despite the provider credentials being active (#8864) fix: update qwen2.5-coder-7b model name (#8861) fix(workflow/nodes/knowledge-retrieval/use-config): Preserve rerankin… (#8842) chore: fix wrong VectorType match case (#8857) feat: add min-connection and max-connection for pgvector (#8841) feat(Tools): add feishu tools (#8800) fix: delete harm catalog settings for gemini (#8829) Add Llama3.2 models in Groq provider (#8831) feat: deprecate mistral model for siliconflow (#8828) fix: AnalyticdbVector retrieval scores (#8803) fix: close log status option raise error (#8826) ...
ZhouhaoJiang
added a commit
that referenced
this pull request
Sep 29, 2024
* feat/new-login: (79 commits) feat: add setup only feat: remove self-host feat: add voyage ai as a new model provider (#8747) docs: add english versions for the files customizable_model_scale_out and predefined_model_scale_out (#8871) fix: #8843 event: tts_message_end always return in api streaming resp… (#8846) Add Jamba and Llama3.2 model support (#8878) fix(workflow): update tagging logic in GitHub Actions (#8882) chore: bump ruff to 0.6.8 for fixing violation in SIM910 (#8869) refactor: update Callback to an abstract class (#8868) feat: deprecate gte-Qwen2-7B-instruct embedding model (#8866) feat: add internlm2.5-20b and qwen2.5-coder-7b model (#8862) fix: customize model credentials were invalid despite the provider credentials being active (#8864) fix: update qwen2.5-coder-7b model name (#8861) fix(workflow/nodes/knowledge-retrieval/use-config): Preserve rerankin… (#8842) chore: fix wrong VectorType match case (#8857) feat: add min-connection and max-connection for pgvector (#8841) feat(Tools): add feishu tools (#8800) fix: delete harm catalog settings for gemini (#8829) Add Llama3.2 models in Groq provider (#8831) feat: deprecate mistral model for siliconflow (#8828) ...
cuiks
pushed a commit
to cuiks/dify
that referenced
this pull request
Oct 8, 2024
lau-td
pushed a commit
to heydevs-io/dify
that referenced
this pull request
Oct 23, 2024
idonotknow
pushed a commit
to AceDataCloud/Dify
that referenced
this pull request
Nov 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…g mode and weights in knowledge retrieval node
Checklist:
Important
Please review the checklist below before submitting your pull request.
dev/reformat(backend) andcd web && npx lint-staged(frontend) to appease the lint godsDescription
In the workflow, where a knowledge retrieval node would automatically revert to the RerankModel when set to WeightedScore.
The problem was caused by missing parameters in the frontend data transmission to the backend.
Fixes #8854
Type of Change
Testing Instructions
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration