Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for complete domain names in the new URL prefix. #8893

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

QuietlyChan
Copy link
Contributor

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

Modify the urlWithPrefix logic to support the input of absolute network paths, facilitating the invocation of third - party interface services.

Fixes

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 💪 enhancement New feature or request labels Sep 29, 2024
@QuietlyChan QuietlyChan changed the title Add support for complete domain names in the new URL prefix. feat: Add support for complete domain names in the new URL prefix. Sep 29, 2024
@QuietlyChan QuietlyChan reopened this Sep 29, 2024
@crazywoola crazywoola requested review from laipz8200 and removed request for laipz8200 October 22, 2024 14:00
@crazywoola crazywoola requested a review from iamjoel November 6, 2024 01:00
iamjoel
iamjoel previously approved these changes Nov 8, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 8, 2024
@crazywoola crazywoola merged commit c1b2243 into langgenius:main Nov 8, 2024
4 checks passed
@QuietlyChan QuietlyChan deleted the feat-url-prefix branch November 11, 2024 01:01
AlwaysBluer pushed a commit to AlwaysBluer/dify that referenced this pull request Nov 14, 2024
idonotknow pushed a commit to AceDataCloud/Dify that referenced this pull request Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 enhancement New feature or request lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants