Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clearly distinguish between url and remote_url of the file #9551

Closed
wants to merge 3 commits into from

Conversation

hjlarry
Copy link
Contributor

@hjlarry hjlarry commented Oct 21, 2024

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

when you want to get a file's url, you will get the null

9104604eb9ce619a6842d316b6ad2d6

so I think clearly distinguish the url and remote_url is necessary

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

test locally

  • Test get the file's url and remote_url in a workflow's end node
  • Test filter the file's url and remote_url in a list operator node

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. 💪 enhancement New feature or request labels Oct 21, 2024
@laipz8200
Copy link
Collaborator

We are aware of this issue and are considering solutions. The File structure is recorded in the message history, so we can't simply swap the url and remote_url. Please feel free to open an issue so we can discuss this matter together.

@hjlarry
Copy link
Contributor Author

hjlarry commented Oct 21, 2024

We are aware of this issue and are considering solutions. The File structure is recorded in the message history, so we can't simply swap the url and remote_url. Please feel free to open an issue so we can discuss this matter together.

OK, I open this issue #9567

@hjlarry hjlarry closed this Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 enhancement New feature or request size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants