-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: chart tool can't display chinese #9686
Conversation
I hope to avoid uploading the font file directly to the code base. It is too large and will slow down the speed of users pulling the code. Do we have a better way to fix this? For example, download fonts when building Docker Image? |
now I changed the implement detail:
local test with windows and docker |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Checklist:
Important
Please review the checklist below before submitting your pull request.
dev/reformat
(backend) andcd web && npx lint-staged
(frontend) to appease the lint godsDescription
Fixes #9657
the font file comes from here https://github.com/adobe-fonts/source-han-sans?tab=License-1-ov-file , please makesure the copyright is OK
Type of Change
Testing Instructions
test locally