Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unstructured pdf extract #9794

Merged
merged 2 commits into from
Oct 24, 2024
Merged

Conversation

JohnJyong
Copy link
Collaborator

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

remove unstructured pdf extract

Fixes

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Oct 24, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 24, 2024
@JohnJyong JohnJyong merged commit 5f11fe5 into main Oct 24, 2024
8 checks passed
@JohnJyong JohnJyong deleted the feat/remove-unstructured-pdf branch October 24, 2024 10:13
@taowang1993
Copy link
Contributor

taowang1993 commented Nov 10, 2024

I wonder why unstructured pdf extractor method got removed from this file.

There is an unstructured_pdf_extractor file inside the unstructured folder.

Why not use unstructured_pdf_extractor when ETL is set to Unstructured?

image

idonotknow pushed a commit to AceDataCloud/Dify that referenced this pull request Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants