Fix Tests on M1 #839
Merged
Fix Tests on M1 #839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #839 +/- ##
=======================================
Coverage 93.88% 93.88%
=======================================
Files 42 42
Lines 9882 9882
=======================================
Hits 9278 9278
Misses 604 604 Continue to review full report at Codecov.
|
odow
approved these changes
Aug 21, 2022
|
FWIW, I just reproduced these two failures as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@odow, these appear to be the only changes that need to be made. Appears to be a slight numerical difference in Julia's builtin
detfunction. I am going to wait to merge to get your input to do a work around or not in this case.