Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matpower conversion #26

Merged
merged 3 commits into from
Jul 12, 2018
Merged

Matpower conversion #26

merged 3 commits into from
Jul 12, 2018

Conversation

rb004f
Copy link
Collaborator

@rb004f rb004f commented Jun 17, 2018

This pull request changes the default input format to follow the matpower conventions

@bluejuniper Take a look at the matpower based input files. I removed redundant/unused data fields that were in the json files. If you see something we should preserve, I will add them back in

@ccoffrin If you see something about the matpower input files that looks strange, let me know. But we should be moved away from the json input files now.

rb004f added 2 commits June 7, 2018 16:53
Beginning the process of converting the source data to a matpower like format
Converted the default inputs to a matpower based input
@ccoffrin
Copy link
Member

ccoffrin commented Jun 17, 2018

In the data files would you consider something like (note curly braces),

%column_names%  hi_bus lo_bus gmd_br_hi gmd_br_lo gmd_k gmd_br_series gmd_br_common baseMVA type config
mpc.branch_gmd = {
	1	3	1	-1	1.793	-1	-1	100	'xf'	'gwye-delta'
	1	2	-1	-1	0	-1	-1	100	'line'	'none'
	2	4	3	-1	1.793	-1	-1	100	'xf'	'gwye-delta'
};

Same goes for gmd_bus. This is basically a short coming of using matricies to specify component data, all values in matricies should have a common type. Cell arrays are the easy way to get around this in InfrastructureModels.

Then I think we can avoid the need for, lanl-ansi/PowerModels.jl#305

Copy link
Member

@ccoffrin ccoffrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one minor suggestion. If the datasets you are using can be made open access (we should discuss the legal details), then I would highly recomend we propose them as an official IEEE PES GMD test set as part of PGLib, https://github.com/power-grid-lib/

%% branch data
% fbus tbus r x b rateA rateB rateC ratio angle status angmin angmax
mpc.branch = [
1 3 0.0001 0.004 0 9000.0 0.0 0.0 1 0.0 1 -29.999999999999996 29.999999999999996
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider touching up the output data writer to clean up the -29.99999 values.

@rb004f
Copy link
Collaborator Author

rb004f commented Jun 18, 2018

Agreed. This was a more elegant way of handling the data. I have updated the data sets accordingly. And, yes, this reduces the need for lanl-ansi/PowerModels.jl#305

@rb004f rb004f merged commit 2dad31f into master Jul 12, 2018
@ccoffrin ccoffrin deleted the matpower_conversion branch July 17, 2018 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants