Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve start speed and decrease celery processes #739

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Improve start speed and decrease celery processes #739

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions beeflow/client/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,20 +186,25 @@ def start_scheduler():
def celery():
"""Start the celery task queue."""
log = open_log('celery')
return subprocess.Popen(['celery', '-A', 'beeflow.common.celery', 'worker'],
# Setting --pool=solo to avoid preforking multiple processes
return subprocess.Popen(['celery', '-A', 'beeflow.common.celery', 'worker', '--pool=solo'],
stdout=log, stderr=log)

# Run this before daemonizing in order to avoid slow background start
container_path = paths.redis_container()
# If it exists, we assume that it actually has a valid container
if not os.path.exists(container_path):
print('Unpacking Redis image...')
subprocess.check_call(['ch-convert', '-i', 'tar', '-o', 'dir',
bc.get('DEFAULT', 'redis_image'), container_path])

@mgr.component('redis', ())
def redis():
"""Start redis."""
data_dir = 'data'
os.makedirs(os.path.join(paths.redis_root(), data_dir), exist_ok=True)
conf_name = 'redis.conf'
container_path = paths.redis_container()
# If it exists, we assume that it actually has a valid container
if not os.path.exists(container_path):
subprocess.check_call(['ch-convert', '-i', 'tar', '-o', 'dir',
bc.get('DEFAULT', 'redis_image'), container_path])
# Dump the config
conf_path = os.path.join(paths.redis_root(), conf_name)
if not os.path.exists(conf_path):
Expand Down Expand Up @@ -372,9 +377,9 @@ def handle_terminate(signum, stack): # noqa
def start(foreground: bool = typer.Option(False, '--foreground', '-F',
help='run in the foreground')):
"""Start all BEE components."""
check_dependencies()
mgr = init_components()
beeflow_log = paths.log_fname('beeflow')
check_dependencies()
sock_path = paths.beeflow_socket()
if bc.get('DEFAULT', 'workload_scheduler') == 'Slurm' and not need_slurmrestd():
warn('Not using slurmrestd. Command-line interface will be used.')
Expand Down