add pre/post script support to flux worker #818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
WIP: Need to test now. |
Fix build docs issue.
…to pre_post_script_flux
…ost_script_flux Rebase to update neo4j driver.
kchilleri
requested review from
jtronge
and removed request for
rstyd and
pagrubel
jtronge
previously approved these changes
May 7, 2024
There was a problem hiding this comment.
This looks good. I tried the clamr-ffmpeg-build_script workflow on our Flux system and the output seems correct. The git history looks a little odd but I think this is just something with github.
I'm going to try to make an integration test for this in another PR.
jtronge
previously approved these changes
May 8, 2024
jtronge
previously approved these changes
May 8, 2024
jtronge
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of pre/post script support PR #788 for the flux worker. Enables pre/post script capabilities in flux_worker.py.