Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix edge case in badge generation. #851

Merged
merged 9 commits into from
Jun 24, 2024
Merged

Conversation

aquan9
Copy link
Collaborator

@aquan9 aquan9 commented Jun 10, 2024

This PR tries to fix edge-case issues discovered in the code coverage badge generation process.

@aquan9 aquan9 added the WIP Work in progress label Jun 10, 2024
@aquan9 aquan9 added WIP Work in progress and removed WIP Work in progress labels Jun 11, 2024
@aquan9 aquan9 changed the title Remove rebase before committing new badge Fix edge case in badge generation. Jun 11, 2024
@aquan9 aquan9 removed the WIP Work in progress label Jun 11, 2024
@aquan9
Copy link
Collaborator Author

aquan9 commented Jun 11, 2024

This should hopefully fix the issues where merges into develop were causing the missing rebase branch.

Copy link
Collaborator

@jtronge jtronge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@rstyd rstyd merged commit 3403efb into develop Jun 24, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants