Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update documentation for the integration tests #887

Merged
merged 3 commits into from
Jul 31, 2024
Merged

Update documentation for the integration tests #887

merged 3 commits into from
Jul 31, 2024

Conversation

jtronge
Copy link
Collaborator

@jtronge jtronge commented Jul 24, 2024

I think this should address issue #859, at least for the integration tests. I've added some more info about what tests are actually being run, how to show those, and how to run tests not on by default.

@jtronge jtronge requested review from pagrubel and aquan9 July 24, 2024 13:19
pagrubel
pagrubel reviewed Jul 25, 2024
View reviewed changes
Copy link
Collaborator

@pagrubel pagrubel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jtronge This looks good. I don't know why but when I build it the reference to the command line interface doesn't work correctly, but it doesn't work correctly for me on develop branch either.

pagrubel
pagrubel requested changes Jul 26, 2024
View reviewed changes
Copy link
Collaborator

@pagrubel pagrubel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found the reference problem, there needs to be two dots in commands.rst at the beginning of line 1 not one dot.

rstyd
rstyd approved these changes Jul 30, 2024
View reviewed changes
Copy link
Collaborator

@rstyd rstyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

rstyd
rstyd approved these changes Jul 30, 2024
View reviewed changes
Copy link
Collaborator

@rstyd rstyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This addresses the requested changes.

@pagrubel pagrubel merged commit 0b85b6c into develop Jul 31, 2024
6 checks passed
@pagrubel pagrubel deleted the issue859/test-docs branch July 31, 2024 16:57
Leahh02 pushed a commit that referenced this pull request Aug 1, 2024
@jtronge
Update documentation for the integration tests (#887)
d5f09eb 
* Update documentation for the integration tests
@pagrubel pagrubel mentioned this pull request Sep 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pagrubel pagrubel pagrubel approved these changes

@rstyd rstyd rstyd approved these changes

@aquan9 aquan9 Awaiting requested review from aquan9

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jtronge @rstyd @pagrubel