Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Start State #914

Merged
merged 15 commits into from
Sep 11, 2024
Merged

No Start State #914

merged 15 commits into from
Sep 11, 2024

Conversation

Leahh02
Copy link
Collaborator

@Leahh02 Leahh02 commented Sep 3, 2024

This should allow the user to cancel a workflow submitted with the no-start state. The correct state should also come up when they query the workflow. The correct state should also appear in the graph database.

@Leahh02 Leahh02 added the WIP (no-ci) Don't run any CI for this PR label Sep 3, 2024
@Leahh02
Copy link
Collaborator Author

Leahh02 commented Sep 3, 2024

I should probably standardize the capitalization. For example, when I query the workflow I get

No Start
cat--No Start
grep0--No Start
grep1--No Start
tar--No Start

and when I start and then query I get

Running
cat--COMPLETING
grep0--WAITING
grep1--WAITING
tar--WAITING

So I need to make it NO START

@pagrubel
Copy link
Collaborator

pagrubel commented Sep 4, 2024

I would think the Workflow state would be Not Started and the tasks could be blank.
Waiting for Submit for the Workflow

@Leahh02
Copy link
Collaborator Author

Leahh02 commented Sep 5, 2024

I would think the Workflow state would be Not Started and the tasks could be blank. Waiting for Submit for the Workflow

I can do that instead!

@Leahh02
Copy link
Collaborator Author

Leahh02 commented Sep 5, 2024

After commit 8ba84cf the output looked like:

No Start
cat--
grep0--
grep1--
tar--

Then in commit 9841e8f I decided to remove the -- so now it looks like:

No Start
cat
grep0
grep1
tar

@Leahh02 Leahh02 removed the WIP (no-ci) Don't run any CI for this PR label Sep 9, 2024
@pagrubel pagrubel requested a review from kabir-vats September 9, 2024 22:26
@pagrubel
Copy link
Collaborator

pagrubel commented Sep 9, 2024

@Leahh02 This looks good to me and works well. You will need to fix the conflicts. I've asked @kabir-vats to review it, if he has time.

@pagrubel pagrubel added WIP (no-ci) Don't run any CI for this PR and removed WIP (no-ci) Don't run any CI for this PR labels Sep 11, 2024
Copy link
Collaborator

@pagrubel pagrubel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition to allow a user to specify a workflow and verify the tasks and a first step in verifying the workflow dependencies.

@pagrubel pagrubel merged commit ad84827 into develop Sep 11, 2024
6 checks passed
@pagrubel pagrubel deleted the Issue901/no-start-state branch September 11, 2024 21:44
@pagrubel pagrubel restored the Issue901/no-start-state branch September 13, 2024 03:39
@pagrubel pagrubel deleted the Issue901/no-start-state branch September 16, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants